[Core] publisher config API #1561
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ecal/samples/cpp/pubsub/binary/binary_zero_copy_snd/src/binary_zero_copy_snd.cpp
Show resolved
Hide resolved
| memory_file_attr.reserve = m_config.memfile_reserve_percent; | ||
| memory_file_attr.timeout_open_ms = PUB_MEMFILE_OPEN_TO; | ||
| memory_file_attr.timeout_ack_ms = m_config.acknowledge_timeout_ms; | ||
|
|
There was a problem hiding this comment.
Maybe extract this into its own function?
SHMConfig -> Publisher::SHM::Configuration UDPConfig -> Publisher::UDP::Configuration TCPConfig -> Publisher::TCP::Configuration
reader Create/Destroy replaced by Constructor/Destructor
…scriber, client, server) Create/Destroy -> Start/Stop
| } | ||
|
|
||
| void CSubGate::Create() | ||
| void CSubGate::Start() |
There was a problem hiding this comment.
warning: method 'Start' can be made static [readability-convert-member-functions-to-static]
ecal/core/src/pubsub/ecal_subgate.h:42:
- void Start();
+ static void Start();| } | ||
|
|
||
| void CClientGate::Create() | ||
| void CClientGate::Start() |
There was a problem hiding this comment.
warning: method 'Start' can be made static [readability-convert-member-functions-to-static]
ecal/core/src/service/ecal_clientgate.h:47:
- void Start();
+ static void Start();| } | ||
|
|
||
| void CServiceGate::Create() | ||
| void CServiceGate::Start() |
There was a problem hiding this comment.
warning: method 'Start' can be made static [readability-convert-member-functions-to-static]
ecal/core/src/service/ecal_servicegate.h:41:
- void Start();
+ static void Start();
rex-schilasky
changed the title
…ged dynamically anymore) frequency calculator reset factor set back to 3.0f
alignment
| UDP::Configuration udp; | ||
| TCP::Configuration tcp; | ||
|
|
||
| bool share_topic_type = true; //!< share topic type via registration |
There was a problem hiding this comment.
we should discuss if we still support this for ecal 6. Also do we need to distinguish between type and descriptor? maybe only allow to switch of descriptor? (but not in this PR)
| #endif | ||
| // register publisher gateway (for publisher memory file and event name) | ||
| if (m_created) return(false); | ||
| if (topic_name_.empty()) return(false); |
There was a problem hiding this comment.
I'm not sure I like this 😨 BUT not for this PR.
| m_use_udp_mc_confirmed(false), | ||
| m_use_shm_confirmed(false), | ||
| m_use_tcp_confirmed(false), | ||
| m_share_ttype(Config::IsTopicTypeSharingEnabled()), |
There was a problem hiding this comment.
@rex-schilasky why do you have config calls here? because we don't yet have the config on subscriber side?
There was a problem hiding this comment.
yes, will be part of the new CSubscriber::Configuration
| @@ -44,7 +44,7 @@ namespace eCAL | |||
| attr.port = UDP::GetPayloadPort(); | |||
There was a problem hiding this comment.
Other question: I think we indirectly access the config here? does it make sense to move also this information to the Publisher::UDP::Configuration? Although we would never want the user to change those.... (just out of curiosity, not relevant for this PR).
Description
Draft implementation of a publisher configuration API in preparation of the new global eCAL configuration API.